Add Element to the type of delimiter#23
Merged
joente merged 2 commits intocesbit:masterfrom Mar 16, 2023
dk949:master
Merged
Conversation
`_validate_element` will convert a sting passed to it to a `Token`, so `str` should also be a valid type of the parameter.
The `delimiter` argument of `List` can be either a string or an `Element`, but the type only specifies `str`.
joente
approved these changes
Mar 16, 2023
Member
joente
left a comment
joente
left a comment
There was a problem hiding this comment.
This is correct, thanks for the pr 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point of the PR is to allow
delimiterargument ofListto be anElement. At present, if the user wants to use an element as a delimiter, the have to usetyping.cast(or# type: ignore) to avoid a type error.The PR also adds
stras a possible type of the argument to_validate_element.Neither of these should cause any change to the runtime behaviour of the library.