Merged
Conversation
UlricQin
reviewed
Jul 14, 2022
src/pkg/common/api.go
Outdated
| @@ -0,0 +1,76 @@ | |||
| package common | |||
Member
There was a problem hiding this comment.
It might be better to change the package name to prom
1.extract server/api.go 2.make webapi reading prom with reusing server's API,not a new prom client
clear code
UlricQin
reviewed
Jul 17, 2022
src/webapi/prom/prom.go
Outdated
| return c, has | ||
| } | ||
|
|
||
| func (cs *ClustersType) GetClusters() []*ClusterType { |
UlricQin
reviewed
Jul 17, 2022
src/webapi/prom/prom.go
Outdated
| opts := config.C.Clusters | ||
|
|
||
| for i := 0; i < len(opts); i++ { | ||
| transport := &http.Transport{ |
Member
There was a problem hiding this comment.
initClustersFromConfig 和 initClustersFromAPI 中有大片代码重复，看看是否可以抽取出方法？
UlricQin
reviewed
Jul 17, 2022
UlricQin
reviewed
Jul 17, 2022
UlricQin
reviewed
Jul 17, 2022
UlricQin
reviewed
Jul 17, 2022
UlricQin
reviewed
Jul 17, 2022
UlricQin
reviewed
Jul 17, 2022
src/webapi/webapi.go
Outdated
| if err = prom.Init(); err != nil { | ||
| return nil, err | ||
| } | ||
| // init reader clients |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
batch query in single request for one panel
What this PR does / why we need it:
the browser limit request num,so when many panel loading metric data, some web request will be block.
Which issue(s) this PR fixes:
no issue fix, but this may be faster,and grafana has implement this.
for code:
Kindly give me your advice,Thanks!