Collection fixes #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the source generator from crashing with a
NullReferenceExceptionfor ICollection types.GetEnumeratorSymbolnow falls back to implemented interfaces when the provided type symbol does not define one. This method was returning null when given anIReadOnlyCollectionand causing the whole generation to fail.TryGetGenericCollectionInterfacewas also expanded to support all related collection interfaces.Tests for both
ICollectionandIReadOnlyCollectionwere also added, but are probably overkill, as it was just the generation that was failing and might not be a necessity for ~300 extra tests.