Skip to content

rename error for 429 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartes merged 1 commit into from
Aug 12, 2024
Merged

rename error for 429 #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/castle/core/process_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module ProcessResponse
403 => Castle::ForbiddenError,
404 => Castle::NotFoundError,
419 => Castle::UserUnauthorizedError,
429 => Castle::TooManyRequestsError
429 => Castle::RateLimitError
}.freeze

INVALID_REQUEST_TOKEN = 'invalid_request_token'
Expand Down
2 changes: 1 addition & 1 deletion lib/castle/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class UnauthorizedError < Castle::ApiError
end

# api error too many requests 429
class TooManyRequestsError < Castle::ApiError
class RateLimitError < Castle::ApiError
end

# all internal server errors
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/castle/core/process_response_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
it_behaves_like 'response_failed', '404', Castle::NotFoundError
it_behaves_like 'response_failed', '419', Castle::UserUnauthorizedError
it_behaves_like 'response_failed', '422', Castle::InvalidParametersError
it_behaves_like 'response_failed', '429', Castle::TooManyRequestsError
it_behaves_like 'response_failed', '429', Castle::RateLimitError
it_behaves_like 'response_failed', '499', Castle::ApiError
it_behaves_like 'response_failed', '500', Castle::InternalServerError
end
Expand Down