Conversation
bartes
force-pushed
the
invalid_token_error
branch
from
11e8fd9 to
4deebad
Compare
madejejej
reviewed
Mar 9, 2022
| if parsed_body.is_a?(Hash) && parsed_body[:type] == INVALID_REQUEST_TOKEN | ||
| return Castle::InvalidRequestTokenError | ||
| end | ||
| rescue JSON::ParserError |
Contributor
There was a problem hiding this comment.
Do we want to assume our API can return an invalid JSON here? Perhaps we could catch JSON::ParserError in the call method instead.
Contributor
Author
There was a problem hiding this comment.
this is also used for the legacy endpoints, I wanted to keep the functionality unchanged if that error type value is not present
Contributor
There was a problem hiding this comment.
Legacy APIs respond with the same format for 422 errors
Contributor
Author
There was a problem hiding this comment.
not sure about eg impersonation endpoints, I prefer to keep that somehow covered
madejejej
reviewed
Mar 9, 2022
lib/castle/core/process_response.rb
Outdated
| end | ||
| end | ||
|
|
||
| Castle::InvalidParametersError |
Contributor
There was a problem hiding this comment.
Would be great to add a proper error message to these exceptions. Or is this going to be a different PR? :)
madejejej
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.