Skip to content

Allow to configure the base api url#213

Merged
marysieek merged 6 commits intodevelopfrom
CAS-5541-base-url
Nov 3, 2020
Merged

Allow to configure the base api url#213
marysieek merged 6 commits intodevelopfrom
CAS-5541-base-url

Conversation

@marysieek
Copy link
Contributor

No description provided.

@marysieek marysieek self-assigned this Nov 3, 2020
@marysieek marysieek requested a review from bartes November 3, 2020 13:20
@marysieek marysieek marked this pull request as ready for review November 3, 2020 13:20
Enabled: false

Style/MethodMissingSuper:
Lint/MissingSuper:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bartes bartes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor readme change

README.md Outdated
config.request_timeout = 2000

# Base Castle Api url.
config.base_url = "https://api.castle.io"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be commented out by default

@marysieek marysieek requested a review from bartes November 3, 2020 14:09
@marysieek marysieek merged commit 2f0da9f into develop Nov 3, 2020
@marysieek marysieek deleted the CAS-5541-base-url branch November 3, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants