fix couple of defects and enhancements: backend service port, css extend error, wrong nginx tap, run require.py without root, nginx user setting, 404 on Chart.min.js, etc#1
Open
alexzhangs wants to merge 8 commits intocaomike:masterfrom
Conversation
the backend service ports in nginx conf template should follow supervisord.nginx.conf.
.icon-40 is extending a non-exist selector in www/scss/_base.scss.
nginx upload module is available in nginx-full which is in tap denji/nginx.
… failure. manos brew doesn't allow to be run under root, but require.py requires being executed under root.
without a proper setting for nginx user, nginx process won't have permission to access to upload path, default is /usr/local/opt/ppmessage, hence uploading files in chat will fail.
somehow bower generated web files refer to Chart.min.js which does not exist instead of Chart.js. didn't find a way to fix this in the source, as a patch, add a step to README to copy this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi gaijin,
I have made a couple of changes on my fork which is based on your latest master branch, including:
Details can be found in each commit log.
I created this pull request, in case you may want to merge the changes.