Skip to content

feat: Add configuration option to skip committee store operations( set/delete) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oten91 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add configuration option to skip committee store operations( set/delete) #280

oten91 wants to merge 5 commits into from

Conversation

@oten91
Copy link
Collaborator

@oten91 oten91 commented Dec 15, 2025 •
edited
Loading

pending:

  • Define actual height
  • probably expend to committeedata space ?

@oten91 oten91 requested a review from rem1niscence December 15, 2025 11:19
rem1niscence
rem1niscence previously requested changes Dec 15, 2025
View reviewed changes
@oten91
feat: Add configuration option to skip committee store operations
e3d0462
@oten91
feat: Add configuration for skipping committee store operations and e…
22c5432 
…nhance state machine handling

fix: enable validator filtering for committee ID 0

Resolved a bug where committee ID 0 was treated as "no filter," causing
incorrect validator sets. Added a FilterByCommittee flag to explicitly
trigger membership checks for the root chain while maintaining
backward compatibility for non-zero IDs.
@oten91
remove commented out code
087d922
@oten91 oten91 force-pushed the not-use-committee-store branch from e27d615 to 087d922 Compare December 19, 2025 16:01
@oten91 oten91 requested a review from rem1niscence December 19, 2025 16:45
@oten91
Copy link
Collaborator Author

oten91 commented Dec 19, 2025

done! please rereview @rem1niscence

also fixed a potential bug while using chain_id 0

fix: enable validator filtering for committee ID 0

Resolved a bug where committee ID 0 was treated as "no filter," causing
incorrect validator sets. Added a FilterByCommittee flag to explicitly
trigger membership checks for the root chain while maintaining
backward compatibility for non-zero IDs.```

@oten91 oten91 requested a review from pablocampogo December 19, 2025 16:48
rem1niscence
rem1niscence requested changes Dec 19, 2025
View reviewed changes
Copy link
Collaborator

@rem1niscence rem1niscence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid and quite explicit to allow for more upgrades in the future, nice!, just a minor comment on style and specially in tests to default for this behavior, please check on them first

@oten91
fix: Update JSON field name for committee filter option, Remove remma…
4e70503 
…nt from testing to use the default statemachineconfig
@oten91 oten91 requested a review from rem1niscence December 19, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rem1niscence rem1niscence rem1niscence approved these changes

@andrewnguyen22 andrewnguyen22 Awaiting requested review from andrewnguyen22

@pablocampogo pablocampogo Awaiting requested review from pablocampogo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oten91 @rem1niscence