-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Open
Labels
DocumentationImprovements or additions to documentationImprovements or additions to documentationMedium PriorityMedium priority issueMedium priority issueMulti-ModuleIssue spans over multiple modulesIssue spans over multiple modulesX-Small Shirt< 1 week worth of work< 1 week worth of work
Description
Describe the bug
The .proto files have a mix of CamelCase and Snake_Case
// MessageEditOrder modifies an un-claimed token swap 'sell order', token amount may be increased or decreased as well
// as the recipient address
// If an order is already 'claimed' or 'bought', the order may not be modified
message MessageEditOrder {
// order_id: is the number id that is unique to this committee to identify the order
// not modifiable, used for order identification only
uint64 OrderId = 1; // @gotags: json:"orderID"
// chain_id: the id of the committee that is responsible for the 'counter asset' the uCNPY will swapped for
// not modifiable, used for order identification only
uint64 ChainId = 2; // @gotags: json:"chainID"
// amount_for_sale: the updated amount of uCNPY listed for sale, a reduction will return escrowed tokens to the seller's
// send address
uint64 AmountForSale = 3; // @gotags: json:"amountForSale"
// requested_amount: the updated amount of the 'counter asset' the buyer must send in order to complete a swap
uint64 RequestedAmount = 4; // @gotags: json:"requestedAmount"
// sellers_receive_address: the address of the seller where the 'counter asset' will be received
bytes SellerReceiveAddress = 5; // @gotags: json:"sellerReceiveAddress"
}message View {
// the unique identifier of the blockchain network
uint64 network_id = 1; // @gotags: json:"networkID"
// the unique identifier of the committee within the blockchain network
uint64 chain_id = 2; // @gotags: json:"chainID"
// the height or number of committed blocks in the blockchain
uint64 height = 3;
// the root blockchain height also the height that the committee validator set may be verified
uint64 root_height = 4; // @gotags: json:"rootHeight"
// each height consists of one or more `rounds` which is a step within the consensus protocol where
// a new Proposer is selected to lead the validators to agree on the next block if they fail, the
// round is incremented, more time is granted for consensus timeouts, and the cycle starts over
uint64 round = 5;
// represents the smallest unit in the consensus process. Each round consists of multiple phases, and these phases are
// executed sequentially to achieve consensus on the next block.
// ELECTION->ELECTION-VOTE->PROPOSE->PROPOSE-VOTE->PRECOMMIT->PRECOMMIT-VOTE->COMMIT->COMMIT-PROCESS
Phase phase = 6;
}Steps to reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '...'
- Scroll down to '...'
- See error
Expected behavior
- Determine the proper protocol and correct this
Additional context
Does not affect functionality
Required Tags
- Priority: Low
- Module: Multi-Module
Metadata
Metadata
Assignees
Labels
DocumentationImprovements or additions to documentationImprovements or additions to documentationMedium PriorityMedium priority issueMedium priority issueMulti-ModuleIssue spans over multiple modulesIssue spans over multiple modulesX-Small Shirt< 1 week worth of work< 1 week worth of work