-
Notifications
You must be signed in to change notification settings - Fork 763
[docs] Remove alias and host from explanation
#4583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tobe2098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ricab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Geoffrey, I understand where you're coming from, but I am a little hesitant to just remove valid content. Have you considered a page for miscellaneous concepts that don't deserve their own pages, perhaps?
@ricab,
|
|
Ah perfect, that makes total sense to me. Do you think that should go in this or a separate PR? |
It is OK to do this in the same PR since a separate PR will still follow the process of deleting the pages, unlinking old references and writing the glossary items. The only step we will have to re-do in this PR is to put back the internal refs that we had deleted and update them with the new reference. |
ricab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @geoffreynyaga, I understand that these were very small for their own pages, but should we really just remove the content altogether?
I am concerned that users may feel a little lost when they encounter these terms. Couldn't we perhaps have a miscellaneous page for such things, or join most of the explanation pages into one?
|
Oh, we've discussed this 😅 Do you still mean to do that glossary thing @geoffreynyaga? |

Description
This PR removes two pages from the explanation section. The pages are
AliasandHostand they lack a good threshold of content to warrant their own independent pages on the Multipass docs.The PR also updates any internal linking to these removed pages to prevent broken links.
Checklist