Skip to content

Added "Drag and drop file to open" feature#220

Closed
mjgupta wants to merge 10 commits intocamicroscope:developfrom
mjgupta:master
Closed

Added "Drag and drop file to open" feature#220
mjgupta wants to merge 10 commits intocamicroscope:developfrom
mjgupta:master

Conversation

@mjgupta
Copy link

@mjgupta mjgupta commented Feb 27, 2020 •
edited by birm
Loading

closes #218

  • Added a drop area in loader.html with basic CSS styling
  • Added events to handle Drop and handle Drag over drop area, which show the working status in the console
  • Linked the events to handle_upload asynchronous function in the chunked_upload.js file
  • Changed chunked_upload.js was due to code formatting used in Visual Studio IDE
  • Loader.js updated with the new functions

Please feel free to notify me for making any suitable changes in the code

@mjgupta mjgupta mentioned this pull request Feb 27, 2020
Closed
@birm birm requested review from birm and nanli-emory February 27, 2020 18:36
birm
birm requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@birm birm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this fully in a bit, but please don't overwrite our .gitignore

@birm birm changed the base branch from master to develop February 27, 2020 18:40
@birm
Copy link
Member

birm commented Mar 9, 2020

@mjgupta if you're still interested, you'll need to fix the merge conflict

mjgupta added 4 commits March 9, 2020 13:59
@mjgupta
.gitignore restored to original
c646d49 
.gitignore of the branch to be merged changed to .gitignore of the original CaMicroscope
@mjgupta
Updated chunked_upload.js
9498713 
Removed unnecessary formatting created by the Visual Studio IDE.
@mjgupta
Removed conflicts in loader.js
abe84dd 
Scripts related to the drag and drop feature have been added in the loader.html file only, loader.js is not changed.
@mjgupta
Updated loader.html
6d02769 
Removed unnecessary conflicting code lines, additional functions for Handling Drop and drag over handler event are added in the file
mjgupta
mjgupta commented Mar 9, 2020
View reviewed changes
Copy link
Author

@mjgupta mjgupta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts in .gitignore , chunked_upload.js , loader.js - Removed unnecessary changes
Appropriate JS functions have been added to loader.html which deal with drag and drop event handling.

@birm
Copy link
Member

birm commented Apr 10, 2020

I hope you don't mind if I close this. The loader code has drifted a fair bit. That's not to say we're not interested in the concept; it could be useful.
Thanks for taking the time to contribute, and apologies that it didn't get merged.

@birm birm closed this Apr 10, 2020
@mjgupta
Copy link
Author

mjgupta commented Apr 21, 2020

Hi @birm can you please check Slack for a message I sent to you privately?
Sorry for replying to this thread, but you weren't active on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birm birm birm requested changes

@nanli-emory nanli-emory Awaiting requested review from nanli-emory

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lack of "Drag and Drop file to open feature" in the application

2 participants

@mjgupta @birm