Make cmake ARCH_INDEPENDENT #416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Just tripped over a weird issue using Fedora's concurrentqueue package. Its generated
concurrentqueueConfigVersion.cmakehas this at the end:which causes
mesonto fail to find the package using itscmakedependency finder, asCMAKE_SIZEOF_VOID_Pis 8.To remove that chunk of cmake completely, it looks like adding
ARCH_INDEPENDENTtowrite_basic_package_version_fileis the thing to do. Certainly regenerating the Fedora package with this patch removes the above and allows meson to find the package, but I avoid cmake at all costs (OR "4" STREQUAL ""?!) so wouldn't like to say it's the best approach...Thanks
PS also noticed the version isn't updated at the top of the CMakeLists.txt.