fix: save workflow button not visible on dev env#14910
fix: save workflow button not visible on dev env#14910CarinaWolli merged 5 commits intocalcom:mainfrom mhetreayush:save-workflow-button-not-visible-on-dev-env
Conversation
|
@mhetreayush is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
workflows
Graphite Automations"Add community label" took an action on this PR • (05/07/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
|
| hideHeadingOnMobile | ||
| heading={ | ||
| session.data?.hasValidLicense && | ||
| (IS_DEV || session.data?.hasValidLicense) && |
There was a problem hiding this comment.
We don't need the IS_DEV check. We an always show the save button, all we need is the banner
There was a problem hiding this comment.
This was added because:
- On the local environment, session.data?.hasValidLicense evaluates to
false, hence making theheadingprop undefined. - The shell component only renders the CTA if the heading is defined.
- Hence, in order to pass in the heading, this check was added.
And wrapping the complete component inside the changes the UI, making it look like this:
If this is okay, we can remove the complete check: IS_DEV || session.data?.hasValidLicense and render the save button regardless of the validLicense
Or
We can just remove the hasValidLicense check.
There was a problem hiding this comment.
@CarinaWolli Let me know what you think about this.
There was a problem hiding this comment.
we can remove the complete IS_DEV || session.data?.hasValidLicense check. I'd love to make it look the same as for routing forms:
|
@CarinaWolli Fixed with 557ae4c 
Also fixed it on the /workflows page:
|
|
Let me know if the changes look good @CarinaWolli |
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
Changes look good now, thank you 🙏
* fix: save workflow button not visible on dev env * refactor: use the CALCOM_ENV constant * fix: ui fix for header on workspace pages * refactor: remove unused variable --------- Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
4 participants
What does this PR do?
This PR renders the "Save" button in edit/create-workflow flow on the development environment.
Fixes #14909
Type of change
How should this be tested?
Mandatory Tasks
Checklist