Skip to content

reverse_proxy: set default values for keepalive if only some of them are set#7318

Merged
francislavoie merged 1 commit intomasterfrom
fix-rp-keepalive-default
Oct 25, 2025
Merged

reverse_proxy: set default values for keepalive if only some of them are set#7318
francislavoie merged 1 commit intomasterfrom
fix-rp-keepalive-default

Conversation

@WeidiDeng
Copy link
Member

If only some of values are set for http keepalive, the default parameters (keepalive, keepalive_interval, keepalive_idle_conns_per_host) won't be set. This make sure these parameters are set for if other parameters are set.

Assistance Disclosure

No AI was used.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Oct 25, 2025
@francislavoie francislavoie added this to the v2.11.0 milestone Oct 25, 2025
@francislavoie francislavoie merged commit abe0aca into master Oct 25, 2025
26 checks passed
@francislavoie francislavoie deleted the fix-rp-keepalive-default branch October 25, 2025 09:15
@mholt
Copy link
Member

mholt commented Oct 27, 2025

Thanks Weidi!

This reminds me, should we raise the default max idle conns per host, for busy proxies? Seems like it usually improves performance based on your tests.

@WeidiDeng
Copy link
Member Author

I retested using wrk, and found out the performance improvements only comes if the server is already busy (400+ client connections), at 100 connections there is no noticeable improvements.

But I guess when the server is idle, there won't be many idle connections lying around anyway.

@github-actions github-actions bot mentioned this pull request Dec 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants