reverse_proxy: set default values for keepalive if only some of them are set#7318
Merged
francislavoie merged 1 commit intomasterfrom Oct 25, 2025
Merged
reverse_proxy: set default values for keepalive if only some of them are set#7318francislavoie merged 1 commit intomasterfrom
francislavoie merged 1 commit intomasterfrom
Conversation
francislavoie
approved these changes
Oct 25, 2025
Member
|
Thanks Weidi! This reminds me, should we raise the default max idle conns per host, for busy proxies? Seems like it usually improves performance based on your tests. |
Member
Author
|
I retested using wrk, and found out the performance improvements only comes if the server is already busy (400+ client connections), at 100 connections there is no noticeable improvements. But I guess when the server is idle, there won't be many idle connections lying around anyway. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If only some of values are set for http keepalive, the default parameters (
keepalive,keepalive_interval,keepalive_idle_conns_per_host) won't be set. This make sure these parameters are set for if other parameters are set.Assistance Disclosure
No AI was used.