reverseproxy: Allow 0 as weights for weighted_round_robin#6681
Merged
francislavoie merged 3 commits intocaddyserver:masterfrom Nov 7, 2024
suciptoid:master
Merged
reverseproxy: Allow 0 as weights for weighted_round_robin#6681francislavoie merged 3 commits intocaddyserver:masterfrom suciptoid:master
0 as weights for weighted_round_robin#6681francislavoie merged 3 commits intocaddyserver:masterfrom
suciptoid:master
Conversation
Change positive to non-negative
francislavoie
approved these changes
Nov 7, 2024
Member
francislavoie
left a comment
francislavoie
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me.
Thanks to @peanutduck for the initial implementation as well.
1 task
dcecile
added a commit
to dcecile/website
that referenced
this pull request
Jan 3, 2025
The old restriction is lifted now that caddyserver/caddy#6681 is merged and released in 2.9.0
|
I've opened a PR for the doc update: caddyserver/website#437 |
mholt
pushed a commit
to caddyserver/website
that referenced
this pull request
Jan 3, 2025
The old restriction is lifted now that caddyserver/caddy#6681 is merged and released in 2.9.0
Member
|
Thank you! |
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
…erver#6681) * Allow 0 as weights Change positive to non-negative * reverseproxy: allow 0 as weighted round robin value * test: add more wrr select test --------- Co-authored-by: peanutduck <peanutduck@yahoo.com>
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resumes the work from #6388