reverse_proxy: add placeholder http.reverse_proxy.retries#6553
Merged
mholt merged 3 commits intocaddyserver:masterfrom Aug 30, 2024
Merged
reverse_proxy: add placeholder http.reverse_proxy.retries#6553mholt merged 3 commits intocaddyserver:masterfrom
mholt merged 3 commits intocaddyserver:masterfrom
Conversation
mholt
requested changes
Aug 30, 2024
Member
mholt
left a comment
There was a problem hiding this comment.
Thanks; yeah if this works for you I guess we can do this. Just one nit on the naming.
mholt
approved these changes
Aug 30, 2024
1 task
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reverse_proxydirective in Caddy already supports a variety of useful placeholders, as documented hereThis pull request proposes the addition of a new placeholder:
{http.reverse_proxy.retries}. This placeholder tracks the number of retries actually performed to communicate with an upstream. I believe this would be a valuable enhancement, providing more detailed insights into load balancing behavior.For example, in a Caddyfile, this placeholder might be used with
log_appendlike this:In the
access.json, this would then appear like this:{ "level": "info", "ts": 1725040156.150035, "logger": "http.log.access.log1", "msg": "handled request", "request": { ... "tls": { "resumed": true, "version": "TLSv1.3", "cipher_suite": "TLS_AES_128_GCM_SHA256", "proto": "h3", "server_name": "healthchecks.rocky.stbu.net" } }, "bytes_read": 0, "user_id": "", "duration": 3.890395979, "size": 9449, "status": 200, "resp_headers": { ... }, "rp_retries": 3, "rp_upstream_latency_ms": 1787.609998, "rp_upstream_duration_ms": 1787.975152, "rp_upstream_host": "localhost:7072" }