Skip to content

cranelift: Don't recompute allocatable register set #8457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameysharp merged 1 commit into from
Apr 26, 2024
Merged

cranelift: Don't recompute allocatable register set #8457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cranelift/codegen/src/machinst/vcode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ impl<I: VCodeInst> VCodeBuilder<I> {
}

fn collect_operands(&mut self) {
let allocatable = PRegSet::from(self.vcode.machine_env());
for (i, insn) in self.vcode.insts.iter().enumerate() {
// Push operands from the instruction onto the operand list.
//
Expand All @@ -522,7 +523,6 @@ impl<I: VCodeInst> VCodeBuilder<I> {
// its register fields (which is slow, branchy code) once.

let vreg_aliases = &self.vcode.vreg_aliases;
let allocatable = PRegSet::from(self.vcode.machine_env());
let mut op_collector =
OperandCollector::new(&mut self.vcode.operands, allocatable, |vreg| {
VCode::<I>::resolve_vreg_alias_impl(vreg_aliases, vreg)
Expand Down