-
Notifications
You must be signed in to change notification settings - Fork 27
Librarify the plug command #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
requested changes
Jul 18, 2024
Collaborator
rylev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a good idea! Thanks! There are a few items I'd like to see cleared up before we merge this though.
rylev
approved these changes
Jul 22, 2024
Collaborator
rylev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good - just one nit.
Signed-off-by: Brian H <brian.hardock@fermyon.com>
mergify bot
referenced
this pull request
in andrzejressel/pulumi-gestalt
Jul 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [wac-graph](https://togithub.com/bytecodealliance/wac) | workspace.dependencies | minor | `0.4.0` -> `0.5.0` | --- ### Release Notes <details> <summary>bytecodealliance/wac (wac-graph)</summary> ### [`v0.5.0`](https://togithub.com/bytecodealliance/wac/releases/tag/v0.5.0) [Compare Source](https://togithub.com/bytecodealliance/wac/compare/v0.4.0...v0.5.0) #### What's Changed - set version 0.5.0-dev by [@​calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/wac/pull/131](https://togithub.com/bytecodealliance/wac/pull/131) - Librarify the plug command by [@​fibonacci1729](https://togithub.com/fibonacci1729) in [https://github.com/bytecodealliance/wac/pull/134](https://togithub.com/bytecodealliance/wac/pull/134) - Rename encode to compose by [@​rylev](https://togithub.com/rylev) in [https://github.com/bytecodealliance/wac/pull/133](https://togithub.com/bytecodealliance/wac/pull/133) **Full Changelog**: bytecodealliance/wac@v0.4.0...v0.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action of plugging components is a useful paradigm for programmatic composition. This PR lifts the logic performed in the CLI
wac plug ...into thewac-graphcrate to make it reusable as an API.