Merged
Conversation
adubrouski
force-pushed
the
full-react-19-support
branch
6 times, most recently
from
f3a55d8 to
e1ff44f
Compare
Contributor
Author
|
Fix for #1858 |
adubrouski
force-pushed
the
full-react-19-support
branch
from
e1ff44f to
5bade1d
Compare
|
Hi can someone please okay this merge! Long awaited feature and fixes. Just 5 mins of maintainer's time. |
Contributor
Author
Hi, you can use Fixed fork . It seems to me that this PR will not be merged into the master in the near future :) |
|
@bvaughn Please merge this for React 19 support. |
|
@bvaughn let's get this merged! |
adubrouski
force-pushed
the
full-react-19-support
branch
from
5bade1d to
d826874
Compare
6 tasks
Owner
|
Updated published as-is to |
6 tasks
|
Worth mentioning somewhere in the changelog that it's introduced the breaking change for WindowScroller render() which now adds an additional |
|
@adubrouski Much thanks for findDOMNode error fix ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test) all passyarn run prettier).yarn run typecheck).React < 16.3.0 has been removed from peer dependencies for safe React.createRef() usage. I think this would be the right decision. We can release a new version and simply drop support for older versions of React.
ℹ️ Tests still work with findDOMNode, because react version in tests is 17. To remove findDOMNode from tests we need use
@testing-library/react, but it should be in separate PR. We can also access node by ref, but this possibility will be removed in next major react release.📦 Fork published on NPM with full react 19 support (if anyone needs it right now)