updated node version for github actions#1562
Conversation
70b1251 to
64d0b7a
Compare
|
Hi @samj1912 Can you please review this one as well? |
|
@SaumyaBhushan did you have a chance to test this and see if it works with node16? |
No I have not @samj1912 |
Signed-off-by: SaumyaBhushan <saumya@knoldus.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 80.52% 81.14% +0.63%
==========================================
Files 163 156 -7
Lines 10740 10362 -378
==========================================
- Hits 8647 8407 -240
+ Misses 1576 1458 -118
+ Partials 517 497 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
dfreilich
left a comment
There was a problem hiding this comment.
Thanks for the help!
Validated here: #1561 (comment)
|
Hi @dfreilich Are we planning to merge this one or do we need to change something here ? |
|
The previous CI failures appear to be flakes. Hopefully this goes green with the latest updates from |
Signed-off-by: SaumyaBhushan saumya@knoldus.com
Summary
updated node version for github actions
Output
Before
Node 12
After
Node 16
Documentation
Related
#1561
Resolves #1561