Bundle maven packaging deps in java plugins#2280
Merged
Conversation
stefanvanburen
added a commit
that referenced
this pull request
Feb 24, 2026
Just noticed this while looking into #2280 and figured we ought to ratchet this up.
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
seems like a reasonable approach to me, assuming we'd test this locally e2e first. just a couple small thoughts
pkwarren
reviewed
Feb 26, 2026
The maven-deps stage uses COPY pom.xml /tmp/pom.xml, but the .dockerignore excluded everything except the Dockerfile from the build context. Add !pom.xml to any .dockerignore when regenerating maven deps so the build context includes the POM file.
pkwarren
reviewed
Feb 26, 2026
Member
pkwarren
left a comment
pkwarren
left a comment
There was a problem hiding this comment.
Just a couple of minor things - this is looking great!
pkwarren
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our fetcher, and adds a standalone tool to render/re-generate Dockerfiles as well, to make them contain the dependencies we need to do maven packaging for a plugin at a known path.
Updates the latest version of each plugin, follow-up PRs will update older versions once we're happy with this approach. Follow-up PR (that likely needs breaking down further) to update all older versions: #2281