Fix popup.less layout issues for Chromium browsers #328
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes layout issues on Chromium browsers due to LayoutFlexNewColumnAlgorithm.
Contributor
Author
|
I didn't have time to test on Firefox, but I don't foresee this causing issues. May want to check still just in case. |
max-baz
approved these changes
Oct 3, 2023
Member
max-baz
left a comment
max-baz
left a comment
There was a problem hiding this comment.
I confirm it fixes the issue on Chromium, thanks! There's no functional difference for Firefox, since it didn't have the issue in the first place (perhaps it defaults to width: min-content). Thanks!
Member
|
@erayd could you ping me on Signal / Wire / Email when you have some time? Let's chat about perhaps cutting a new release some time soon? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes layout issues on Chromium browsers due to LayoutFlexNewColumnAlgorithm.