Skip to content

suggest to use URL constructor in pg-pool readme #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

suggest to use URL constructor in pg-pool readme #3073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/pg-pool/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,16 @@ The Pool constructor does not support passing a Database URL as the parameter. T

```js
const Pool = require('pg-pool');
const url = require('url')

const params = url.parse(process.env.DATABASE_URL);
const auth = params.auth.split(':');

const databaseUrl = new URL(process.env.DATABASE_URL);

const config = {
user: auth[0],
password: auth[1],
host: params.hostname,
port: params.port,
database: params.pathname.split('/')[1],
user: databaseUrl.username,
password: databaseUrl.password,
host: databaseUrl.searchParams.get('host') || databaseUrl.hostname,
database: databaseUrl.pathname.split('/')[1],
port: databaseUrl.port,
ssl: true
};

Expand Down