Refactor api to something much simpler #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I seem to have missed checking the "Open With Default" command as it doesn't work right now; let me fix that |
Contributor
Author
|
Actually, instead of spending time on getting this "Open With Default" thing working, why not just inform users to download this package? |
Let users download the excellent "Open In Default Application" plugin
located here:
https://packagecontrol.io/packages/Open%20in%20Default%20Application
it's pointless to have double functionality.
Owner
|
OK, 😳 wow... thanks! I didn't know about that package, but it seems like the way to go. Kinda forgot about Windows compatibility there. I'm gonna test this and then merge asap! |
Contributor
Author
|
You're welcome! |
Owner
|
@rwols it seems duplicating directories has been broken by this. |
Owner
|
Nevermind, I think I got it. Gotta use |
Contributor
Author
|
Right... I only tested that with single files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed a lot of old cruft after you gutted the original repo. SideBarAPI.py is now completely gone, as it isn't actually needed anywhere. The whole thing is now just about 100 lines of python code.