fix(build): remove stale guest dir reference in clean script#431
Merged
DorianZheng merged 1 commit intomainfrom Apr 4, 2026
Merged
fix(build): remove stale guest dir reference in clean script#431DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
The guest crate moved into the workspace (src/guest/) but clean.sh still referenced a top-level "guest" directory. The [ -d "guest" ] && pattern fails with set -e when the directory doesn't exist, causing make clean to exit 1 before completing all clean stages. The root cargo clean already handles src/guest as a workspace member, so the separate clean was unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ -d "guest" ] && (cd guest && cargo clean)fromscripts/clean.shguestcrate is now a workspace member atsrc/guest/, so rootcargo cleanalready handles itmake cleanto fail with exit 1 due toset -e+&&pitfall when the top-levelguestdirectory doesn't existTest plan
make cleancompletes successfully (exit 0)