Rudimentary support for the Facebook Canvas#247
Conversation
|
Thanks for your pull request. I think we ought to make this a separate module called facebookCanvas. You can inherit from the facebook module to do this via: everyauth.facebook.submodule("facebookCanvas")
.configurable({canvasPage: "..."})
// Your other extensions follow with the
// same chained method calls in your pull request, placing this code under modules/facebookCanvas.js |
|
And don't forget to update the README for the pull request. Thanks! |
|
Ok, thanks for the feedback. I have my hands pretty full these days, so I can't predict how long it will take me to make it production-ready, but I'll keep you up to date. As for the signature validation, are you using any specific library for SHA hashing? Is there one you'd accept adding as a dep to the project? |
|
Node has a built-in crypto module. See the following for docs and an example: |
|
Perfect! Thanks! |
|
I'm starting to get back to this. I was able to implement the crypto part, so thanks again for the tip. About the everyauth submodule recommendation: looking at the other modules, I see that none of them are importing "everyauth". Instead, they are using everymodule. Is that what you meant? |
|
Give it a try. I've taken care of all the todo's, and moved it to a separate submodule. |
Rudimentary support for the Facebook Canvas
|
Thanks, finally merged this in. |
|
@bnoguchi I was wondering if there is any reason why the facebook canvas module hasn't been included in the express-3 branch. We tried to use it in a project and it seems to work correctly. Is there any design choice to remove it or is it something that can be added? |
|
@fabriziomoscon I was wondering the same thing for about a month or so. |
I added changes to facebook.js to support Facebook Canvas apps:
http://developers.facebook.com/docs/appsonfacebook/tutorial/
This is related to issue #146 (#146)
This version requires two new configurations:
There are several "to-do's" in here: