accomplished objectives and stretch goals#221
Open
ThomasKisner wants to merge 1 commit intobloominstituteoftechnology:masterfrom
Open
accomplished objectives and stretch goals#221ThomasKisner wants to merge 1 commit intobloominstituteoftechnology:masterfrom
ThomasKisner wants to merge 1 commit intobloominstituteoftechnology:masterfrom
Conversation
zackhitch
approved these changes
Aug 10, 2018
zackhitch
left a comment
zackhitch
left a comment
There was a problem hiding this comment.
Outstanding job with this project! Loved to see you implement the stretch goals as well! Keep it up!
| @@ -1 +1,118 @@ | |||
| // CODE here for your Lambda Classes | |||
| class Person{ | |||
| } | ||
| } | ||
|
|
||
| class Instructor extends Person{ |
| this.favSubjects = studentParams.favSubjects; | ||
| this.grade = studentParams.grade; | ||
| } | ||
| listsSubjects(...favSubjects){ |
There was a problem hiding this comment.
No need to pass params here, just loop over the favSubjects array.
| } | ||
| } | ||
|
|
||
| class Student extends Person{ |
| } | ||
|
|
||
| class ProjectManagers extends Instructor{ | ||
| constructor(PmParams){ |
There was a problem hiding this comment.
Convention would be to keep the first letter lowercase on variables/parameter names.
| standup(channel){ | ||
| return `${this.name} announces to ${channel}, @channel standy times`; | ||
| } | ||
| debugsCode(student, subject){ |
| // The console.log() statements should still return what is expected of them. | ||
|
|
||
| function GameObject(options) { | ||
| class GameObject{ |
|
|
||
| function CharacterStats(characterStatsOptions) { | ||
| GameObject.call(this, characterStatsOptions); | ||
| class CharacterStats extends GameObject{ |
|
|
||
| function Humanoid(humanoidOptions) { | ||
| CharacterStats.call(this, humanoidOptions); | ||
| class Humanoid extends CharacterStats{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.