Skip to content

1.9.2-0.0.1: [fix] - Replaced Transactions #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lnbc1QWFyb24 merged 2 commits into from
Jan 26, 2022
Merged

1.9.2-0.0.1: [fix] - Replaced Transactions #222

lnbc1QWFyb24 merged 2 commits into from
Jan 26, 2022

Conversation

@lnbc1QWFyb24
Copy link
Collaborator

@lnbc1QWFyb24 lnbc1QWFyb24 commented Jan 26, 2022

Description

  • Updates SDK to fix transaction payloads
  • Fixes bug where replacement transaction notifications were not being replaced correctly

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@lnbc1QWFyb24 lnbc1QWFyb24 changed the base branch from master to develop January 26, 2022 21:29
@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 1cc1f25 into develop Jan 26, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the fix/replaced-txs branch January 26, 2022 21:30
@freeatnet
Copy link

freeatnet commented Feb 6, 2022

@aaronbarnardsound gm! Did you mean to lock bnc-sdk to 4.0.0? If not, I'm happy to submit a patch so that it can be updated to 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axelKingsley axelKingsley axelKingsley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lnbc1QWFyb24 @freeatnet @axelKingsley