fix validation type coercion for comparison queries in issue #7#8
Merged
weixiyen merged 1 commit intoblitzstudios:masterfrom Apr 23, 2018
pablohirafuji:master
Merged
fix validation type coercion for comparison queries in issue #7#8weixiyen merged 1 commit intoblitzstudios:masterfrom pablohirafuji:master
weixiyen merged 1 commit intoblitzstudios:masterfrom
pablohirafuji:master
Conversation
Collaborator
|
Thank you for the fix! Will update to 0.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, the issue is only when comparing
:texttype fields. It does not happen when the field is:bigintor:timestampbecause it does not pass through this validation:defp coerced_value(value, :text) when not is_binary(value), do: to_string(value)It was passing the list parameter directly to:
defp coerced_value(value, _), do: valuebecause it doesn't have a case that match
when is_liston thecoerced_valuefunction. Only:textbecause lists are anot is_binarymatch.