Skip to content

Comments

[bitnami/postgresql]: configurable data source credentials for postgresql exporter#36465

Open
snosratiershad wants to merge 3 commits intobitnami:mainfrom
snosratiershad:feature/postgres-metrics-configurable-user
Open

[bitnami/postgresql]: configurable data source credentials for postgresql exporter#36465
snosratiershad wants to merge 3 commits intobitnami:mainfrom
snosratiershad:feature/postgres-metrics-configurable-user

Conversation

@snosratiershad
Copy link

@snosratiershad snosratiershad commented Feb 17, 2026

Description of the change

Added auth.metricsUsername and auth.metricsPassword which will be used as postgresql exporter data source username and password if user is not empty and not postgres. Also binded to secrets to support password files.

Benefits

I can use my custom user with non-admin permissions and just pg_monitor in postgresql exporter

Possible drawbacks

I've tried to make it backward compatible so previous values will not break. But the metrics user is not autogenerated and may confuse users.

Applicable issues

Additional information

Update: currently ready to merge

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Copy link
Contributor

@aravind4799 aravind4799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the get-chart check failed because the chart version hasn't been incremented. Bitnami's automation requires a version bump in Chart.yaml for every change.

@javsalgar
Copy link
Contributor

Hi! Thanks for the PR! Yes, it's mandatory, could you bump the version so we can run some verifications?

… exporter

Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>
@snosratiershad snosratiershad force-pushed the feature/postgres-metrics-configurable-user branch from f0000af to 8bfee4d Compare February 19, 2026 18:12
@snosratiershad snosratiershad changed the title [bitnami/postgresql]: draft: configurable data source credentials for postgresql exporter [bitnami/postgresql]: configurable data source credentials for postgresql exporter Feb 19, 2026
@snosratiershad
Copy link
Author

@javsalgar @aravind4799. Version bumped. readme gereneted. squashed.

Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Feb 20, 2026
@github-actions github-actions bot removed the triage Triage is needed label Feb 20, 2026
@github-actions github-actions bot removed the request for review from javsalgar February 20, 2026 08:44
@github-actions github-actions bot requested a review from gongomgra February 20, 2026 08:44
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress postgresql verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] Configurable DATA_SOURCE_USER and similar from values of postgres exporter

5 participants