Send PayJoin #119
Closed
Send PayJoin #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change interface to accept a bip21 PjUri as defined in bip78. Only use address from the bip21 Uri, still pass amount in as a separate argument to send_sats.
cryptoquick
requested changes
Dec 16, 2022
Member
cryptoquick
left a comment
cryptoquick
left a comment
There was a problem hiding this comment.
Wow, nice! Just one change requested. I'm also going to see if I can write an automated test for this.
| base64 = { package = "base64-compat", version = "1.0" } | ||
| bech32 = "0.9" | ||
| bip39 = "1.0" | ||
| bip78 = { git = "https://github.com/dangould/rust-payjoin", rev = "8d9b7d6", features = ["sender" ] } |
Member
There was a problem hiding this comment.
We need this to be published in order to publish our crate.
Collaborator
Author
|
Were you able to smoke test a payjoin on testnet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change interface to accept a bip21 PjUri as defined in bip78. Only use address from the bip21 Uri, still pass amount in as a separate argument to send_sats.
I think the design choices to consider are mostly around passing how we'd like to pass the bip21 from send_sats. Where is the web interface that uses this?
The other question is whether or not to finalize and broadcast the original_psbt in the case of an unresponsive pj endpoint.
This was my first time handling errors in rust with anyhow. Wow, much ease!
May I please have some testnet sats tb1pn4g2sjt0qw9t43lj28quhnajs064n8frzalqjqueuvcas4h6hxlsau59qd ? I can't find a faucet to pay a bitmask taproot address. so futuristic.
You can get a bip21 receiver for this payjoin sender at https://testnet.demo.btcpayserver.org/login to test on testnet