Add workspace with lib and initial cli#14
Merged
notmandatory merged 2 commits intomasterfrom Jun 5, 2023
Merged
Conversation
79a1202 to
e874243
Compare
e874243 to
ed25c61
Compare
Member
Author
|
@brh28 I fixed the CI issue by changing the workspace to exclude the |
Collaborator
|
I follow the basics of what you're saying but don't know enough about MSRV to offer any insight, so no issues from my end |
brh28
approved these changes
Jun 5, 2023
Collaborator
|
ACK ed25c61 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create workspace with separate packages for the
rust-cktaplib and a newcktap-clibinary. Thecktap-cliproject is just a skeleton with two commands partially implemented. Starts but doesn't finish work for #11.Notes to the reviewers
One of the goal of the cli project is to present different help and commands depending on which card the user is using.
Changelog notice
rust-cktapinto workspace lib directory.cktap-clibinary also in workspace cli directory.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: