Skip to content

Add workspace with lib and initial cli#14

Merged
notmandatory merged 2 commits intomasterfrom
workspace_cli
Jun 5, 2023
Merged

Add workspace with lib and initial cli#14
notmandatory merged 2 commits intomasterfrom
workspace_cli

Conversation

@notmandatory
Copy link
Member

Description

Create workspace with separate packages for the rust-cktap lib and a new cktap-cli binary. The cktap-cli project is just a skeleton with two commands partially implemented. Starts but doesn't finish work for #11.

Notes to the reviewers

One of the goal of the cli project is to present different help and commands depending on which card the user is using.

Changelog notice

  • Move rust-cktap into workspace lib directory.
  • Create skeleton cktap-cli binary also in workspace cli directory.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory notmandatory self-assigned this Jun 4, 2023
@notmandatory
Copy link
Member Author

@brh28 I fixed the CI issue by changing the workspace to exclude the cktap-cli project if building for the MSRV. I really only care about the MSRV for the rust-cktap lib. It's a bit of a hack but no better way right now besides not using workspaces at all, and most users will be using stable rust and then it's nice to have everything in a workspace.

@brh28
Copy link
Collaborator

brh28 commented Jun 5, 2023

I follow the basics of what you're saying but don't know enough about MSRV to offer any insight, so no issues from my end

@brh28
Copy link
Collaborator

brh28 commented Jun 5, 2023

ACK ed25c61

@notmandatory notmandatory merged commit ed25c61 into master Jun 5, 2023
@notmandatory notmandatory deleted the workspace_cli branch June 5, 2023 14:47
@notmandatory notmandatory mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants