Skip to content

feat: add v2alpha1 CRD#414

Open
binbin-li wants to merge 1 commit intomainfrom
add-crd
Open

feat: add v2alpha1 CRD#414
binbin-li wants to merge 1 commit intomainfrom
add-crd

Conversation

@binbin-li
Copy link
Owner

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@binbin-li binbin-li force-pushed the add-crd branch 7 times, most recently from 8499ff8 to 3f0a4c7 Compare June 25, 2025 03:28
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 71.64179% with 57 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (3f32f50) to head (43b9fcd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/manager/manager.go 0.00% 28 Missing ⚠️
internal/controller/executor_controller.go 35.48% 16 Missing and 4 partials ⚠️
internal/executor/executor.go 92.17% 6 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (71.64%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   74.03%   74.31%   +0.28%     
==========================================
  Files         121      120       -1     
  Lines        6789     6856      +67     
==========================================
+ Hits         5026     5095      +69     
+ Misses       1555     1550       -5     
- Partials      208      211       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@binbin-li binbin-li force-pushed the add-crd branch 3 times, most recently from 0a5dc3c to 1e6984c Compare June 25, 2025 04:39
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant