#2 #3 #5 Assignments for php java #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public void askForInputAndRun() { | ||
| /** | ||
| * @todo Check if user input is empty in all the subsequent classes |
Owner
There was a problem hiding this comment.
Complete the task associated to this TODO comment. 
|
|
||
| public void endRun() { | ||
| System.out.println("-----------------------------------------"); | ||
| System.out.println("-----------------------------------------\n\n"); |
Owner
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger.
|
|
||
| public void run() { | ||
| this.initiateRun(); | ||
| System.out.println("->Please Enter the Number of Multiplier"); |
Owner
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger.
| this.numberOfMultiple = scanner.nextInt(); | ||
| System.out.println("->Please Enter First Multiplier"); | ||
| this.firstMultiplier = scanner.nextInt(); | ||
| System.out.println("->Please Enter Second Multiplier"); |
Owner
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger.
Owner
|
SonarQube analysis reported 48 issues:
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bhuwang, please review the code. I have added @todo to check if the user input is empty. I will be doing this as an improvement. Thanks.