maintain the validator instance to speedup schema validation process#55
Merged
janw merged 3 commits intobcwaldon:masterfrom Feb 9, 2020
Merged
Conversation
Contributor
|
Hey @yinyinl, thanks! Good catch; please go ahead and remove the benchmark test, I'll be happy to merge this after that. 👍 |
janw
suggested changes
Feb 8, 2020
Contributor
janw
left a comment
janw
left a comment
There was a problem hiding this comment.
Just remove the test_benchmark and this is good to go.
Contributor
Author
|
Removed the timing benchmark test that was meant for PR review purpose only. Feel free to squash the commits into single one during merging to master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a schema (and possibly a resolver), jsonschema creates a validator first by compiling the schemas and uses it to validate data. If inside the class object, the validator instance is maintained, the validation overhead can be reduced, instead of creating a new validator every time.
In this PR,
test_benchmarkintest_core.pyis to measure the timing difference for the PR review. It can be removed once we finish reviewing and discussing.