Undo changes to the warlock.model_factory API#39
Merged
janw merged 1 commit intobcwaldon:masterfrom Nov 2, 2019
Merged
Conversation
The changes introduced by commit 64a771d ("Allow resolver to be set on the Model") added a new keyword argument to the `warlock.model_factory` function. Due to the way Python handles positional arguments, the change alters the way that existing code is interpreted. Before the change, warlock.model_factory(schema_arg, snd_pos_arg) would execute with kwargs == { 'base_class': snd_pos_arg, 'name': None, } but after the change it's interpreted as kwargs == { 'resolver': snd_pos_arg, 'base_class'=model.Model, 'name': None, } This commit re-arranges the arguments to restore the previous behaviour in an effort to not break existing code.
nathanielknight
force-pushed
the
conserve-api
branch
from
2e934fc to
463334e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes introduced by commit 64a771d ("Allow
resolver to be set on the Model") added a new keyword argument to the
warlock.model_factoryfunction. Due to the way Python handlespositional arguments, the change alters the way that existing code is
interpreted.
Before the change,
would execute with
but after the change it's interpreted as
This commit re-arranges the arguments to restore the previous behaviour
in an effort to not break existing code.