chore: add method to get the default validator#292
Merged
filmakarov merged 1 commit intodevfrom Oct 21, 2025
Merged
Conversation
chore: add method to get the default validator
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on refactoring the
constructorof theModuleManagercontract, enhancing the retrieval of the default validator, and cleaning up unused functions related to pre-validation hooks.Detailed summary
constructorto use parameter names with a trailing underscore.getDefaultValidator()function to retrieve the default validator address._uninstallPreValidationHook()function parameters._getPreValidationHook()and_withPreValidationHook()with improved logic._getEnableModeDataHash()function with updated visibility.