Only start session if hasn't already been started#2392
Closed
dwightwatson wants to merge 1 commit intobcit-ci:developfrom
dwightwatson:develop
Closed
Only start session if hasn't already been started#2392dwightwatson wants to merge 1 commit intobcit-ci:developfrom dwightwatson:develop
dwightwatson wants to merge 1 commit intobcit-ci:developfrom
dwightwatson:develop
Conversation
Signed-off-by: Dwight Watson <dwight@studentservices.com.au>
Contributor
|
I have never seen this warning. Can you give more information about your PHP environment, and the exact warning text? |
Author
|
This is the error that I get: The __construct() function in MY_Controller simply calls |
Contributor
|
Please see #2374 and the comments on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 3.0-dev I get a notice warning that a session has already been started, even though the only call to
session_start()in the app is the one in theSession_native.phpfile.This will only call
session_start()if the session does not exist, to prevent a warning.Signed-off-by: Dwight Watson dwight@studentservices.com.au