Draft
Conversation
|
Hi! Is this still in the works? I was playing around with upgrading the java version using the battlecode23 engine over here. I've run into most of the same issues that you have. That is:
I've noticed some built-in Java containers use less bytecodes in Java 17 than before, which is neat (assuming that's not a bug), so I think an upgrade would be really valuable for competitors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades JDK version from 1.8 to 1.17. This PR is incomplete: if you have ideas on how to elegantly resolve the remaining tasks below, we'd greatly appreciate your contribution!
Completed tasks:
Remaining tasks todo:
jdk.internalpackage, specifically thejdk.internal.misc.Unsafeclass. If rewritten toinstrumented.jdk.internal, the native linkage fails. If left untouched, the "modules" feature from Java 9 blocks access from rewritten packages such asinstrumented.java.util.Random. One choice that works is to add the JVM arguments--add-opens java.base/jdk.internal.misc=ALL-UNNAMED, I'm not sure what other implications this may have. Another option may be to investigate how to use theModuleLayerclass.IllegalAccessExceptions. For example,java.util.Arrays.sortreads private members ofjava.util.Arrays.LegacyMergeSort. Somewhere during classloading, Java has come to believe that the latter is not nested in the former, and rejects this read.