Adding cleanup() method to RiakCluster & RiakClient for container environments #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
suggested changes
Sep 28, 2016
.travis.yml
Outdated
| script: | ||
| - if [ $RIAK_FLAVOR == "riak-kv" ]; then mvn -Pitest,default -Dcom.basho.riak.yokozuna=false | ||
| verify; else echo "Not riak-kv flavor"; fi | ||
| verify; for i in {1..10}; do mvn -Ptest-debug-logging surefire:test -Dtest=RiakClusterTest; done; else echo "Not riak-kv flavor"; fi |
Contributor
Author
There was a problem hiding this comment.
Yeah, trying to track down a very slippery heisenbug.
| RiakCluster cluster = new RiakCluster.Builder(builder.build()).build(); | ||
| cluster.start(); | ||
| return new RiakClient(cluster); | ||
|
|
Contributor
There was a problem hiding this comment.
Here kid, have a newline.
| * Call this method when your application is being unloaded from the container, <b>after</b> | ||
| * all {@link RiakNode}, {@link RiakCluster}, and {@link com.basho.riak.client.api.RiakClient} | ||
| * objects are in the shutdown state. | ||
| */ |
Contributor
There was a problem hiding this comment.
Should this just be part of shutdown?
Contributor
Author
There was a problem hiding this comment.
Nah, b/c:
- If "the user" instantiated 2 RiakCluster or RiakClient objects for some reason, it could clear all the Netty threadlocals if one is still running.
- It would turn
shutdown()into a partially synchronous method, as we'd have to wait for the shutdown future to finish, then call cleanup. - This is only for environments that swap out classloaders.
lukebakken
approved these changes
Sep 28, 2016
Contributor
|
|
once you nuke that newline :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660 (CLIENTS-962), abstracts away the calls needed to cleanup Netty's thread local variables, so we don't leak classloaders into permgen memory upon container reload.
cc/ @monday0rsunday