Skip to content

add watch os as target to decompose #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arkivanov merged 2 commits into from
May 28, 2021
Merged

add watch os as target to decompose #156

arkivanov merged 2 commits into from
May 28, 2021

Conversation

@plusmobileapps
Copy link
Contributor

@plusmobileapps plusmobileapps commented May 27, 2021 •
edited
Loading

Overview

try to setup watchOS support by following similar pattern to tvOS

Questions

I would like to add a sample for watchOS before merging, but would we need to also update MVI Kotlin to support watchOS? Or just good enough to merge as is and create another issue for making a sample?

Issue

Issue #155

plusmobileapps
plusmobileapps commented May 27, 2021
View reviewed changes
plusmobileapps
plusmobileapps commented May 27, 2021
View reviewed changes
arkivanov
arkivanov suggested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@arkivanov arkivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the new target to the build and publish workflows.

@arkivanov
Copy link
Contributor

arkivanov commented May 27, 2021

And also please add the badge to the README :-)

@arkivanov
Copy link
Contributor

arkivanov commented May 27, 2021

Regarding watchos sample, I don't think it is really necessary, but we can discuss it separately. We also don't have samples for macos or tvos. There are tests, they should verify if everything is alright.

@plusmobileapps
update workflow files for build and publish to include WATCHOS. Updat…
1fe2f86 
…e readme and documentation for supported targets
@arkivanov arkivanov merged commit b8313ac into badoo:master May 28, 2021
@arkivanov arkivanov mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arkivanov arkivanov arkivanov requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plusmobileapps @arkivanov