Allow default value for String/Numeric Sets to be unset #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in aws#112 had the side effect of calling `type_cast` on `nil` if the `default_value` was unset. Because the `StringSetMarshaler` and `NumericSetMarshaler` both convert `nil` to `Set.new`, this caused the unset default value in practice to become `Set.new` instead of `nil`. Ultimately this caused downstream effects such as always persisting empty or unset sets as `nil` despite the `#persist_nil?` returning `false`.
mullermp
approved these changes
Sep 25, 2023
Contributor
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
Looks good. Thank you for your contribution.
Contributor
|
We're planning a few other changes to aws-record before releasing a new version. Do you have a workaround for now? |
Contributor
Author
|
Thank you!
@mullermp for now we can use a custom |
mullermp
pushed a commit
that referenced
this pull request
Sep 27, 2023
Contributor
|
I've released this today among other things. Please give this a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The fix in #112 had the side effect of calling
type_castonnilif thedefault_valuewas unset.Because the
StringSetMarshalerandNumericSetMarshalerboth convertniltoSet.new, this caused the unset default value in practice to becomeSet.newinstead ofnil.Ultimately this caused downstream effects such as always persisting empty or unset sets as
nildespite the#persist_nil?returningfalse.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.