Skip to content

Readme/Docs update #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jterapin merged 8 commits into from
Jan 17, 2023
Merged

Readme/Docs update #128

jterapin merged 8 commits into from
Jan 17, 2023

Conversation

@jterapin
Copy link
Contributor

@jterapin jterapin commented Jan 17, 2023 •
edited
Loading

Description of changes:

  • Updated documentation for more visibility between pages and added more details for clarification
  • Updated Readme to include a Table of Contents, information/examples on Item Operations and Transactions
  • Removed License Comments and added # frozen_string_literal: true to each file
    • Updated some methods that were modifying string literals
  • Updated aws-record.gemspec to pull the correct gem version and files
  • Updated version.rb to pull the correct gem version as well

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

alextwoods
alextwoods approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jterapin jterapin marked this pull request as ready for review January 17, 2023 21:17
@jterapin jterapin merged commit 8045bb8 into main Jan 17, 2023
@jterapin jterapin deleted the clean_up branch January 17, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alextwoods alextwoods alextwoods approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jterapin @alextwoods