feat(parser): add IPv6 support for sourceIp in API Gateway schemas #4398
+74
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated api-gateway.ts to support both IPv4 and IPv6 addresses - Updated api-gatewayv2.ts to support both IPv4 and IPv6 addresses - Updated appsync-shared.ts to support both IPv4 and IPv6 addresses - Added comprehensive tests for IPv6 support in all affected schemas Closes aws-powertools#4348
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
boring-cyborg
bot
added
parser
sdangol
requested changes
Aug 29, 2025
- Reverted IPv6 support in appsync-shared.ts (AppSync doesn't support IPv6 yet) - Removed IPv6 test cases from appsync.test.ts - Kept IPv6 support for API Gateway and API Gateway v2 only As mentioned in issue aws-powertools#4348, AppSync does not currently support IPv6
|
I've also marked the SonarQube findings as safe since the ip is hardcoded just for the tests. |
pull-request-size
bot
added
size/M
sdangol
requested changes
Aug 29, 2025
- Replace 'as any' with proper TypeScript types in test files - Use APIGatewayProxyEvent type for API Gateway tests - Use APIGatewayProxyEventV2 type for API Gateway v2 tests - Import types from '../../../src/types/schema.js' This addresses code review feedback for better type safety
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds IPv6 support for sourceIp fields in API Gateway, API Gateway v2, and AppSync parser schemas.
Changes
packages/parser/src/schemas/api-gateway.tsto accept both IPv4 and IPv6 addresses forsourceIpfieldpackages/parser/src/schemas/api-gatewayv2.tsto accept both IPv4 and IPv6 addresses forhttp.sourceIpfieldpackages/parser/src/schemas/appsync-shared.tsto accept arrays of both IPv4 and IPv6 addresses forsourceIpfieldTesting
packages/parser/tests/unit/schema/apigw.test.tspackages/parser/tests/unit/schema/apigwv2.test.tsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
Closes #4348