refactor: idempotency env service to functions 4246 #4314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
boring-cyborg
bot
added
idempotency
|
@dreamorosi Thanks for the clear scope and guidance, let me know how I did when you get a chance. |
svozza
reviewed
Aug 12, 2025
svozza
approved these changes
Aug 12, 2025
|
|
Thank you for the contribution, merging now! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Idempotency utility to replace the
EnvironmentVariablesServiceclass-based approach with functional helper utilities from the commons package. The changes eliminate class inheritance and instantiation in favor of direct function calls, improving performance, reducing bundle size, and increasing consistency across the Powertools codebase.Changes
EnvironmentVariablesServiceinstantiation with directgetBooleanFromEnv()call forPOWERTOOLS_IDEMPOTENCY_DISABLEDenvironment variableEnvironmentVariablesServiceusage with directgetStringFromEnv()call forAWS_LAMBDA_FUNCTION_NAMEenvironment variable#private field syntaxEnvironmentVariablesService.tsand associated test filesRelated Work: This continues the architectural modernization started in #4251 (Logger utility), applying the same functional pattern to the Idempotency utility as part of the broader initiative to eliminate class-based environment services across all Powertools packages.
Issue number: closes #4246 & #4247
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.