refactor(batch): improve code quality in test handlers #4281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have noticed the |
svozza
reviewed
Aug 6, 2025
|
svozza
approved these changes
Aug 6, 2025
|
Thanks so much @dwrth, this looks good to go now! |
uttam282005
pushed a commit
to uttam282005/powertools-lambda-typescript
that referenced
this pull request
Aug 7, 2025
…s#4281) Co-authored-by: David <75678655+David-Werth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR resolves the code quality issues mentioned in #4248 by implementing base handlers which are then reused for both the synchronous and asynchronous handlers.
With this approach we avoid duplicate code and enforce DRY principles.
Issue number: closes #4248
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.