-
Notifications
You must be signed in to change notification settings - Fork 171
refactor(tracer): fix code quality issues #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tracer): fix code quality issues #4264
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, I left only one comment - after it's addressed I'll be happy to merge it!
|
Thank you for this PR and for helping making this project better! We have a few other items similar to this in complexity and scope, if you're interested take a look here. |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Co-authored-by: David <75678655+David-Werth@users.noreply.github.com>
Summary
Changes
This PR fixes the code quality issues found by SonarCube mentioned in this ticket by refactoring the following:
Tracer.test.ts:
memberVariable
ofLambda
asreadonly
Subsegment
instantiationsTracer.ts:
setCaptureHTTPsRequests
setOptions
withthis
Issue number: closes #4257
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.