Skip to content

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Aug 4, 2025

Summary

Changes

Please provide a summary of what's being changed

This PR refactors slightly the AppSync GraphQL event handler so that the aggregate and throwOnError flags have default values at the registry level, rather than when registering the handler - this helps remove code branches and increase test coverage.

Additionally, the PR adds missing unit test cases for decorator-based usage of batch query and mutation resolvers.

Finally, the PR consolidates the Vitest config according to the latest guidance.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4260


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Aug 4, 2025
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility tests PRs that add or change tests labels Aug 4, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Aug 4, 2025
@dreamorosi dreamorosi requested review from sdangol and removed request for sdangol August 4, 2025 17:20
@dreamorosi dreamorosi requested a review from sdangol August 4, 2025 17:26
@dreamorosi dreamorosi requested review from svozza and removed request for sdangol August 5, 2025 08:25
Copy link

sonarqubecloud bot commented Aug 5, 2025

@dreamorosi dreamorosi merged commit c21dec5 into main Aug 5, 2025
34 checks passed
@dreamorosi dreamorosi deleted the test/appsync_graphql branch August 5, 2025 14:25
uttam282005 pushed a commit to uttam282005/powertools-lambda-typescript that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-handler This item relates to the Event Handler Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: test coverage misreported in AppSync Event Handler
2 participants