Skip to content

fix(event-sources): handle dynamodb null type as none, not bool #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2021
Merged

fix(event-sources): handle dynamodb null type as none, not bool #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a962aed
fix(event-sources): return for none for null types
michaelbrewer Dec 27, 2021
2c7a0ac
Merge branch 'develop' into fix-928
michaelbrewer Dec 29, 2021
e49a858
chore: remove misleading test
michaelbrewer Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions aws_lambda_powertools/utilities/data_classes/dynamo_db_stream_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,13 @@ def ns_value(self) -> Optional[List[str]]:
return self.get("NS")

@property
def null_value(self) -> Optional[bool]:
def null_value(self) -> None:
"""An attribute of type Null.

Example:
>>> {"NULL": True}
"""
item = self.get("NULL")
return None if item is None else bool(item)
return None

@property
def s_value(self) -> Optional[str]:
Expand Down
1 change: 1 addition & 0 deletions tests/functional/test_data_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ def test_dynamo_attribute_value_null_value():
attribute_value = AttributeValue(example_attribute_value)

assert attribute_value.get_type == AttributeValueType.Null
assert attribute_value.null_value is None
assert attribute_value.null_value == attribute_value.get_value


Expand Down