Skip to content

feat(logger): allow handler with custom kwargs signature #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021
Merged

feat(logger): allow handler with custom kwargs signature #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws_lambda_powertools/logging/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def handler(event, context):
)

@functools.wraps(lambda_handler)
def decorate(event, context):
def decorate(event, context, **kwargs):
lambda_context = build_lambda_context_model(context)
cold_start = _is_cold_start()

Expand Down
13 changes: 13 additions & 0 deletions tests/functional/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,3 +597,16 @@ def handler(event, context):
first_log, second_log = capture_multiple_logging_statements_output(stdout)
assert "my_key" in first_log
assert "my_key" not in second_log


def test_inject_lambda_context_allows_handler_with_kwargs(lambda_context, stdout, service_name):
# GIVEN
logger = Logger(service=service_name, stream=stdout)

# WHEN
@logger.inject_lambda_context(clear_state=True)
def handler(event, context, my_custom_option=None):
pass

# THEN
handler({}, lambda_context, my_custom_option="blah")